-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Update ReportScreen to display MoneyRequest Reports #18538
Conversation
Is this ready to review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mollfpr Can you please sync with main and update the checklist, I think we should merge this to simplify testing, it should not cause any problems
Reviewer Checklist
Screenshots/VideosNot accessible through the App and confirmed this does not cause regressions on current usecase WebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
We just need the author checklist now I think @mollfpr |
Working on it. |
Complete the checklist. We're good to go @Julesssss @mountiny |
But have we tested each platform? 😕 |
Added a web video test. |
Thank you! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.13-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.13-5 🚀
|
Details
this is to show the money request header when user navigates to the ReportScreen with iou or expense report. Not accessible normally through the App.
Fixed Issues
$ #18474
Tests
N/A Not accessible normally through the App.
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-05-09.at.18.03.44.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android